Skip to main content Link Search Menu Expand Document (external link)

aries-mobile-agent-react-native GitHub

PR #468 fixed biometrics hang if user closed app while onboarding
Signed-off-by: wadeking98 <wkingnumber2@gmail.com> # Summary of Changes Previously if the user closed the app at the biometrics screen, then opened it again, they would get stuck on the splash screen after clicking continue. This was due to `store.authentication.didAuthenticate` being reset after the app gets reopened. Since `didAuthenticate` gets reset to false the agent is never initialized on the splash screen. I changed the commitPIN functionality to set the user as authenticated if it is able to load the wallet secret. That way the user can close the app between the create PIN screen and the biometrics screen and still be considered authenticated by the app # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [ ] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [ ] Updated documentation as needed for changed code and new or modified features; - [ ] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-10-05 18:51:39 +0000 UTC
PR #467 fix: align colours between proof request and details screen
# Summary of Changes Align colours between proof request and details screen. # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [ ] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [ ] Updated documentation as needed for changed code and new or modified features; - [ ] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-10-04 22:02:46 +0000 UTC
PR #466 disable app biometrics when phone biometrics is disabled
Signed-off-by: wadeking98 <wkingnumber2@gmail.com> # Summary of Changes If user enables biometrics during onboarding and then disables biometrics on the phone after app has been initialized, then the next time the user opens the app, they will be notified that biometrics has been disabled on the app and they will be prompted to enter their PIN. ![biometricsChanged](https://user-images.githubusercontent.com/36937407/193895755-add2b28c-1127-489b-8ef4-99b4ed7a5402.png) # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [x] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [x] Updated documentation as needed for changed code and new or modified features; - [x] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-10-04 18:23:54 +0000 UTC
PR #465 chore: update screen styling for a11y
# Summary of Changes This PR introduces style changes to accommodate a11y features such as zoomed displays. Various screens now incorporate ScrollViews in the event content runs off the screen. Buttons are now, by standard, fixed to the bottom of screens (which should allow for refactoring screens into a common form component). Test snapshots have been updated accordingly. # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [ ] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [ ] Updated documentation as needed for changed code and new or modified features; - [ ] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-10-03 22:34:23 +0000 UTC
PR #464 changed back buttons on tabstack
Signed-off-by: wadeking98 <wkingnumber2@gmail.com> # Summary of Changes Removed back buttons from the tab stack that were pointing back to the splash screen. Removed back button title from all screens ![image](https://user-images.githubusercontent.com/36937407/193647665-bffb240e-7c3c-4cf7-a837-e083c01580bd.png) ![image](https://user-images.githubusercontent.com/36937407/193647776-54b0568c-081f-4496-86b4-f58fb8e6a5c3.png) ![image](https://user-images.githubusercontent.com/36937407/193647918-ccc02045-adf4-4e63-886a-112332bc618b.png) # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [x] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [x] Updated documentation as needed for changed code and new or modified features; - [x] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-10-03 18:09:40 +0000 UTC
PR #463 feat: move defaultConfiguration
# Summary of Changes This PR allows us to import the default configuration into our customizations so that we can decompose the default configuration for the pages we don't want to edit. # Related Issues Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues. N/A Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [x] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [x] Updated documentation as needed for changed code and new or modified features; - [x] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-10-03 12:02:53 +0000 UTC
PR #459 fix: ellipses display on credential card for android
# Summary of Changes Ellipses are shown in both iOS and Android if text wraps more than 1 line for consistent display between platforms. # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [ ] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [ ] Updated documentation as needed for changed code and new or modified features; - [ ] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-09-30 23:04:36 +0000 UTC
PR #458 Feat auth with wallet unlock
# Summary of Changes Changed CheckPIN function to load wallet salt instead. Reverted changes to loadWalletSecret function # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [x] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [x] Updated documentation as needed for changed code and new or modified features; - [x] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-09-29 23:24:44 +0000 UTC
PR #457 fix: patch agent provider in AFJ extensions
# Summary of Changes This PR adds a patch to the AFJ Agent provider extension to eliminate having to pass the agent by props in the component tree. It exposes a setter method instead. Eventually this should replace the implementation in the AFJ Extensions. This fixes an issue that recently emerged in the Splash screen with the refactor of the app initialization. The Splash screen needs to be able to set the agent on initialization but cannot receive state function via props since it is customizable via configuration therefore the component signature cannot be enforced. # Related Issues N/A # Pull Request Checklist Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR **check it anyway** to make it apparent that there's nothing to do. - [ ] All commits contain a DCO `Signed-off-by` line (we use the [DCO GitHub app](https://github.com/apps/dco) to enforce this); - [ ] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components; - [ ] Updated documentation as needed for changed code and new or modified features; - [ ] Added sufficient [tests](../__tests__/) so that overall code coverage is not reduced. If you have _any_ questions to _any_ of the points above, just **submit and ask**! This checklist is here to _help_ you, not to deter you from contributing! Pro Tip - Read our [contribution guide](../CONTRIBUTING.md) at least once; it will save you a few review cycles! - Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed. _PR template adapted from the Python attrs project._
Created At 2022-09-29 19:31:42 +0000 UTC