Skip to main content Link Menu Expand (external link) Document Search Copy Copied

iroha GitHub

PR #3110 [fix] #3109: Prevent sumeragi sleep after role agnostic message
Bugiroha2Consensus ### Description of the Change Changes tend to improve sumeragi message processing speed. - Fix bug when iroha sleep after role-agnostic message - Refactor view change proof chain and improve it's processing speed. ### Issue Closes #3109. ### Benefits Better sumeragi message processing speed. ### Possible Drawbacks None. ### Alternate Designs There is still problem with: ``` This peer is faulty. Incoming messages have to be dropped due to low processing speed. ``` This happens because sumeragi blocks on committing/revalidating block and if it takes time greater than `pipeline` `ViewChangeSuggested` start flooding queue. When queue is full it's staring to drop messages which in turn provoke even more `ViewChangeSuggested` messages.
Created At 2023-02-02 07:48:43 +0000 UTC
PR #3108 [feature] #3099: Sub-routing for status endpoint
Enhancementiroha2 ### Description Improved sub-routing of the `status` endpoint. ### Issue Closes #3099 ### Benefits #### Routing One does not need to decode JSON in order to obtain a subset of the data. Specifically this can be used for makeshift healthchecking. #### Colour Additional checks for the standard terminal colour specifications are implemented. Specifically, if the environment variable `TERMINAL_COLORS` is defined and not equal to `false`, and the current `stdout` supports colour (i.e. isn't redirected to a file), additional colour is applied to the `cli` messages. If either of the above is false, terminal colour is disabled. Including logging and panic hooks. #### Minor fixes Running Iroha with a non-existent configuration file no longer directly produces a failure. Instead data is deserialised from the environment and errors from there are forwarded. ### Possible Drawbacks None ### Usage Examples or Tests *[optional]* ```sh curl http://127.0.0.1:8180/status/blocks ``` Should return a single number, while ```sh curl curl http://127.0.0.1:8180/status ``` should return a set of JSON values. ```sh NO_COLOR=true cargo run --bin iroha ``` results in Screenshot 2023-02-05 at 22 33 09 While ```sh cargo run --bin iroha ``` Screenshot 2023-02-05 at 22 34 46
Created At 2023-02-02 03:07:15 +0000 UTC
PR #3106 [feature]: #1618: Replace builtin validators with runtime validators
Enhancementiroha2api-changesbuildRefactorUI ### Description of the Change Builtin validators replaced by runtime validators. See commits for more details ### Issue #1618 ### TODO in this PR - [ ] Fix tests - [ ] Fix conflicts - [ ] Fix commit names
Created At 2023-02-01 20:39:03 +0000 UTC
PR #3104 [refactor]: Remove adt_const_generics nightly feature
iroha2 Signed-off-by: Marin Veršić <marin.versic101@gmail.com> ### Description of the Change Relevant [discussion](https://github.com/hyperledger/iroha/pull/3047#discussion_r1091485179) If many of you disagree we'll reject this PR ### Issue ### Benefits ### Possible Drawbacks ### Usage Examples or Tests *[optional]* ### Alternate Designs *[optional]*
Created At 2023-02-01 09:08:55 +0000 UTC
PR #3098 [fix] #2599: Remove nursery lints
iroha2 ### Description of the Change Nursery lints are explicitly disabled. The lints which were enabled as part of `clippy::nursery` are instead enabled individually. ### Issue Closes #2599 ### Benefits Smoother toolchain upgrade process ### Possible Drawbacks New lints have to be explicitly enabled. Migitation: - On each upgrade uncomment `clippy::nursery` and see the effects of new lints.
Created At 2023-01-30 18:44:07 +0000 UTC
PR #3097 [fix] #3087: Collect votes from observing peers after view change.
iroha2 Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com> ### Description of the Change ### Issue ### Benefits ### Possible Drawbacks ### Usage Examples or Tests *[optional]* ### Alternate Designs *[optional]*
Created At 2023-01-30 15:21:40 +0000 UTC
PR #3096 [feature] #3094: Generate network with `n` peers
iroha2 Signed-off-by: Shanin Roman <shanin1000@yandex.ru> ### Description of the Change Extend `./scripts/test_env.sh` to work with arbitrary number of nodes. Add option to kagami to generate peers in compact format. ### Issue Closes #3094 ### Benefits Easier to test iroha with different number of peers. ### Possible Drawbacks None. ### Usage Examples or Tests *[optional]* ```bash # run 10 peers without docker ./scripts/test_env.sh setup bare 10 # run 10 peers with docker ./scripts/test_env.sh setup docker 10 ```
Created At 2023-01-30 15:03:23 +0000 UTC
PR #3091 [fix] #3056: Fix `tps-dev` benchmark hanging
Bugiroha2 Signed-off-by: Shanin Roman <shanin1000@yandex.ru> ### Description of the Change Problem was that transaction submitter accidentally produced duplicate transactions and it's thread paniced without blockchain reaching enough blocks. - Fix verification for `If` instruction; - Add nonce to tps benchmark transactions; - Log and ignore benchmark transaction submitter; - Transfer assets if have at least 2; - Maximum TTL for transaction on client side; ### Issue Closes #3056. ### Benefits Stable benchmark. ### Possible Drawbacks None. ### Usage Examples or Tests ```bash cargo bench --bench tps-dev ```
Created At 2023-01-30 07:47:20 +0000 UTC